Update notebooks for eta file creations #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oelbert
approved these changes
May 7, 2024
|
I was just thinking that especially when the goal is just to write out files, perhaps it'd be better to change move/convert the notebook to a python script in this PR. @fmalatino, this PR is not readly |
|
I see the PR is re-opened and all tests pass, @mlee03 is this ready to be merged? |
|
'tis ready |
fmalatino
added a commit
that referenced
this pull request
Jan 6, 2025
* working baroclinic test case example (#81) * fixing dockerfile overriding netcdf, mpi4py, and numpy versions with mutually incompatible versions (#84) * Update notebooks for eta file creations (#85) * Update pace to use python 3.11.9 (#82) * Updated container for Github Action and reusable workflow (#87) * Updated container for Github Action and reusable workflow - Redo (#89) * Matching packages between main and develop branches and removal of outdated pull request template (#86) * Changed workflows to use python 3.11.7, added pytest-subtests to requirments_dev.txt * Updating constraints file * Updating Dockerfile to use 3.11-slim-bookworm base python image * reusable workflow CI - checkout corrrect repository (#90) * pace/tests/main/grid/test_eta.py moved to NDSL/tests/grid/test_eta.py (#92) * Updated README to include directions for generating eta files (#99) * Updated submodules to most recent versions as of 3 Jan 2025 15:35 EST * Updated c5 build script to match new methods --------- Co-authored-by: Oliver Elbert <[email protected]> Co-authored-by: MiKyung Lee <[email protected]> Co-authored-by: mlee03 <[email protected]> Co-authored-by: Xingqiu Yuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR,
generate_eta_files.ipynbhas been added. This notebook will generate theeta79.ncandeta91.ncfiles that are used in tests/main. This notebook will be used as part of CI to generate input files on-the-fly.In addition, the notebooks
generate_eta_file_netcdf.ipynbandgenerate_eta_file_xarray.ipynbhave been removed. Contents ofgenerate_eta_file_xarray.ipynbare contained in the new notebook. And since the files can be generated withgenerate_eta_files.ipynb,generate_eta_file_netcdf.ipynbhas been removed.Fixes # (issue)
How Has This Been Tested?
The jupyter notebook was converted to a python script (for convenience) and executed. The contents of the generated netcdf files were checked against the original data in class HybridPressureCoefficients
Checklist: