Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NASA] Clean up for PR 41 #43

Merged
merged 1 commit into from
Dec 7, 2023
Merged

[NASA] Clean up for PR 41 #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fv3core/tests/savepoint/translate/translate_a2b_ord4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def __call__(
vort,
delpc,
dt,
grid_type: int,
grid_type: int, # TODO: swap grid_type type hint when refactor into an enum
):
# this function is kept because it has a translate test, if its
# structure is changed significantly from __call__ of DivergenceDamping
Expand Down Expand Up @@ -80,6 +80,7 @@ def compute_from_storage(self, inputs):
nord_col,
nord_col,
)
# TODO: use proper grid_type values when refactor into an enum
inputs["grid_type"] = 0
self.compute_obj(divdamp, **inputs)
return inputs