Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sixth reconciliation PR from production/RRFS.v1 #365

Open
wants to merge 3 commits into
base: dev/emc
Choose a base branch
from

Conversation

grantfirl
Copy link

Description

This PR is identical to NOAA-EMC#89 from @MatthewPyle-NOAA

Provides the atmos_cubed_sphere changes needed to take advantage of FMS parallel IO changes. Changes courtesy of Dan Kokron of GDIT.

Fixes # (issue)

How Has This Been Tested?

UFS WM regression tests on Hera using full rt.conf file.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grantfirl
Copy link
Author

@bensonr @XiaqiongZhou-NOAA You may want to re-review. I made one small change to turn ENABLE_PARALLELRESTART to OFF by default in CMakeLists.txt since turning it on caused UFS WM RT failures on some platforms. Turning this feature off by default was deemed a good temporary solution to get the functionality merged into develop for platforms that need it and use it, although they'll need to make sure to turn it on in their workflows somehow and not rely on the default behavior to do it for them. See NOAA-EMC/fv3atm#896 for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants