Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allocate heat_source when SKEB is True and d_con is zero #351

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

NeilBarton-NOAA
Copy link

Description

The model fails when d_con is zero and skeb is True because heat_source is unallocated. This change allocates heat_source when skeb is True

Fixes # (issue)

No issue previously assigned.

How Has This Been Tested?

The code has been tested in the gefs forecasting in g-w. Currently testing rt.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for submitting this change.

@FernandoAndrade-NOAA
Copy link

#2278 is ready, please continue with the merge process, thank you.

@bensonr
Copy link
Contributor

bensonr commented Aug 12, 2024

@NeilBarton-NOAA - Did you create an issue for this PR? I want to make sure it gets closed.

@bensonr bensonr merged commit 3f81533 into NOAA-GFDL:dev/emc Aug 12, 2024
@NeilBarton-NOAA
Copy link
Author

@bensonr I did not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants