Add GNSSRO yaml files #67
Open
+1,152
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuanliLi-NOAA
requested review from
ADCollard,
emilyhcliu,
jianjunj,
nicholasesposito,
CoryMartin-NOAA and
danholdaway
|
Commented-out QCs have been removed from the YAML files. |
emilyhcliu
reviewed
Jan 17, 2025
Comment on lines
+35
to
+53
| # Apply gross check using pccf | ||
| # Step 0-A: Create Diagnostic Flags | ||
| # Diagnostic flag for pccf | ||
| - filter: Create Diagnostic Flags | ||
| filter variables: | ||
| - name: bendingAngle | ||
| flags: | ||
| - name: pccfCheckReject | ||
| initial value: false | ||
| force reinitialization: true | ||
|
|
||
| # Diagnostic flag for qfro | ||
| - filter: Create Diagnostic Flags | ||
| filter variables: | ||
| - name: bendingAngle | ||
| flags: | ||
| - name: qfroCheckReject | ||
| initial value: false | ||
| force reinitialization: true |
There was a problem hiding this comment.
We will not be using "Create Diagnostic Flags" for QC flags because, with this method, we will be creating a diagnostic flag variable for each filter. This could make the output diagnostic file huge.
We are aiming to create one variable to store QC decisions.
So, my suggestion is that you remove the diagnostic flag variables (pccfChecReject and qfroCheckReject) if you do not need them to do anything. But If they help you diagnose problems at the current stage, it is good to keep them for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding gnssro_mission.yaml.j2 data. The GNSS RO data is reorganized so each satellite mission has its own yaml file.