Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stat analysis template #10

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Add stat analysis template #10

merged 4 commits into from
Dec 13, 2024

Conversation

kevindougherty-noaa
Copy link
Contributor

Add stat analysis template jinja file used for stat analysis job in global workflow.

@danholdaway
Copy link
Collaborator

For now you need to create a branch with the same name in the jcb repo to get the CI to pass. You don't have to make a PR, but you have to push a branch with the same name.

Since this new algo involves obs spaces I think you should add a section for it here: https://github.com/NOAA-EMC/jcb-algorithms/blob/develop/observer_components.yaml This ensures you only end up with the parts of the observer YAMLs that you actually need.

Copy link
Collaborator

@danholdaway danholdaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding. A couple of minor comments.

@kevindougherty-noaa
Copy link
Contributor Author

@danholdaway Thank you for reviewing Dan, just pushed a branch in jcb. Do you mind expanding on your second point from above? I am not quite sure I fully understand what you are asking. Thank you!

@danholdaway
Copy link
Collaborator

Seeing your jcb-gdas branch perhaps this isn't relevant. Since you aren't using the main observation YAML files but creating new ones in a new stats directory. So this is good to go.

@danholdaway danholdaway merged commit e854bd8 into develop Dec 13, 2024
1 check passed
@danholdaway danholdaway deleted the feature/stats-workflow branch December 13, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants