-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GNSSRO bufr2ioda and json files #1448
base: develop
Are you sure you want to change the base?
Conversation
Should these go in here or in |
@CoryMartin-NOAA In the meanwhile, @nicholasesposito will create these low-level Pythons into one Python script with high-level API and mapping files. These will be checked into SPOC. Once we have most of the Python Script, mapping files in SPOC, we will work on GDASApp to use them from SPOC. |
ok sounds good thanks @emilyhcliu I just wanted to double check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few minor comments, and I didn't closely look at the converters but assume they have been thoroughly tested
@@ -0,0 +1,805 @@ | |||
#!/usr/bin/env python3 | |||
# (C) Copyright 2023 NOAA/NWS/NCEP/EMC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we are putting dates in all of these, they should probably be 2025 not 2023. We can also just not put dates in it at all, we don't need to put a license string in every file like the JCSDA does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The date line has been removed from the python scripts.
@XuanliLi-NOAA one question. No worries, what you have in this PR is OK. But. we should try to create one Python script with high-level Python API for GPSRO. |
Co-authored-by: Cory Martin <[email protected]>
…C/GDASApp into feature/gnssro_bufr2ioda
@emilyhcliu , it would be great to have one Python script to convert all platforms. Yes, let's do that with the with high-level Python API. |
Do all GPSRO platform use the same bufr table? |
@emilyhcliu, yes, for the test date 00z 2024-02-19, they use the same bufr table. But after June 2024, we have new EUMETSAT Spire data, this has an additional BUFR mnemonic "SASBID". Should we consider that in the high level python API? @XuanliLi-NOAA Yes, we should include the new one. It is good that all platforms share the same bufr table mnemonics. We can have one mapping file to handle all of them. So, the one Python script with high-level API should be doable for GPSRO. |
Description
Add JSON and bufr2ioda python scripts for GNSSRO data. Each GNSSRO mission has a separate ioda obs file.
Companion PRs
N/A
Issues
Refs #750
Automated CI tests to run in Global Workflow