Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terms and condition #854

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Conversation

Megha-Dev-19
Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 commented Jun 23, 2024

Resolves #847
TODO:

  • Deploy changes on contract
  • I will have to change the blockheight once the terms and condition widget is deployed

@Megha-Dev-19 Megha-Dev-19 marked this pull request as ready for review July 8, 2024 08:10
@Megha-Dev-19 Megha-Dev-19 requested a review from Tguntenaar as a code owner July 8, 2024 08:10
@Megha-Dev-19
Copy link
Collaborator Author

@Tguntenaar, we have to add these changes to events as well.

@petersalomonsen
Copy link
Collaborator

should we put some effort into figuring out why the blog tests are so flaky @Tguntenaar ?

@Tguntenaar
Copy link
Collaborator

@petersalomonsen yes we should, I'm working on the blog search performance / a bug that ori had found. Let's see what happens when we re-run this gh action one more time.

I thought it was RPC related but that should not be the case anymore with your rpc cache enhancements right?

@petersalomonsen
Copy link
Collaborator

@petersalomonsen yes we should, I'm working on the blog search performance / a bug that ori had found. Let's see what happens when we re-run this gh action one more time.

I thought it was RPC related but that should not be the case anymore with your rpc cache enhancements right?

Don't think it is RPC related anymore. It is more probably performance related, laggy components etc. I can take a look at it too, unless you've already found some clues to follow?

@Megha-Dev-19 Megha-Dev-19 merged commit f492594 into NEAR-DevHub:main Jul 8, 2024
7 checks passed
@petersalomonsen
Copy link
Collaborator

@Tguntenaar Back here: 3d6e5d8, we had tests failing because of using variables inside styled divs. Any chance that this could be the case here too? I see flashes of the same error message as back then which is "VM is dead".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new T&C log to Events & DevHub proposal create timeline
3 participants