Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: confirmation only for add/edit post #216

Merged

Conversation

petersalomonsen
Copy link
Collaborator

@petersalomonsen petersalomonsen commented Jul 29, 2023

This fix will check the method name of the returned transaction and only show the post confirmation screen if it is edit_post or add_post. This means that for a like, it will just return to the feed, and not show any confirmation screen. Also the confirmation screen now shows that post is added or edited.

Preview URL: https://near.org/devgovgigs.petersalomonsen.near/widget/gigs-board.pages.Feed?nearDevGovGigsContractAccountId=devgovgigs.petersalomonsen.near

fixes #209

check the method name of the returned transaction
only show the post confirmation screen if it is edit_post or add_post

fixes NEAR-DevHub#209
@petersalomonsen petersalomonsen marked this pull request as ready for review July 29, 2023 18:28
@petersalomonsen
Copy link
Collaborator Author

petersalomonsen commented Aug 2, 2023

@ori-near You might also want to review this, since you reported the bug.

Also check out #217 proposing how to remove the confirmation screen entirely.

Copy link
Collaborator

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and test works to me!

@ailisp ailisp merged commit ad2570e into NEAR-DevHub:main Aug 3, 2023
@petersalomonsen petersalomonsen deleted the fix/inaccurate-post-submitted-message branch August 3, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The post submitted successfully message is sometimes inaccurate
2 participants