Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove post added / edited confirmation screen #217

Open
petersalomonsen opened this issue Jul 30, 2023 · 3 comments
Open

Remove post added / edited confirmation screen #217

petersalomonsen opened this issue Jul 30, 2023 · 3 comments
Labels
enhancement New feature or request Has dependency A ticket that has a dependency on another ticket. Remove when dependency is removed.

Comments

@petersalomonsen
Copy link
Collaborator

The newly introduced screen confirming that post was successfully added/edited leads to extra steps, and slows down the experience when creating/editing multiple posts.

After a post transaction is successfully executed you should be returned directly to the created / edited post in view mode ( no editor ). Either in the feed, if that's where you came from, or directly to the post.

The reason for the new confirmation screen is for pure technical reasons, to remove the draft state and clear the transactionHashes query string parameter ( as written in the PR where it was introduced: #197 ).

It would be better if this parameter could be cleared by an automatic redirect, but this is not possible in NEAR social VM as of today, so a feature for this would need to be requested there.

Another alternative would be to keep the transactionHashes parameter in the query string, but clear the draft by inspecting the submitted content in the transaction and comparing it with the draft, and only clear the draft if it matches. This would also serve as a better confirmation for that the post is actually edited/submitted successfully. But without clearing the transansactionHashes then it would be preserved in the query string for future posts, and also if reloading the view, it would also look up that transaction, and it's unclear how that would work with multiple posts, so a redirect to clear the query string parameter would be appropriate in any case.

@ori-near
Copy link
Collaborator

ori-near commented Aug 3, 2023

Thank you @petersalomonsen for creating this. I added the Has Dependency tag since there is work required on the NEAR Social VM first: NearSocial/VM#93.

@ailisp
Copy link
Collaborator

ailisp commented Nov 24, 2023

Update the estimation to 2 weeks as also count work in social VM

@petersalomonsen
Copy link
Collaborator Author

After learning more about the VM, I think maybe what we want is cache invalidation after a transaction.

NearSocial/VM#156 does this if the user is signed into the devhub contract, which can be tested in the preview URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Has dependency A ticket that has a dependency on another ticket. Remove when dependency is removed.
Projects
Status: 🆕 Triage
Development

No branches or pull requests

3 participants