Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a STAC item for HLS_VI granules #21

Merged
merged 21 commits into from
Jul 29, 2024
Merged

Create a STAC item for HLS_VI granules #21

merged 21 commits into from
Jul 29, 2024

Conversation

SwordSaintLancelot
Copy link
Collaborator

PR is created to create an STAC item for the HLS_VI granule.

Script description

generate_stac_items.py is the script that generates a STAC item for the HLS_VI granule.
In order to create the item, the script requires the cmr xml file of the HLS_VI granule along with the file name that should contain the STAC item in JSON format. It also requires the DAAC information from where the data is being fetched.

Other arguments and information are provided within the script in the form of function descriptions and arguments.

Copy link
Collaborator

@chuckwondo chuckwondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some unit tests and also expose an entry point for the command line (see https://github.com/NASA-IMPACT/hls-vi/blob/main/setup.py#L15-L20)

@chuckwondo
Copy link
Collaborator

@chuckwondo
Copy link
Collaborator

@SwordSaintLancelot, you can run linting and test locally by running the following, as mentioned in the README.md:

make test

That should show you the same errors as the CI build, so you can address them locally before pushing your changes.

@chuckwondo
Copy link
Collaborator

You must also add missing dependencies to the install_requires list in setup.py. I see that you're missing pystac, geojson, and perhaps others.

@SwordSaintLancelot
Copy link
Collaborator Author

@chuckwondo The code has been updated and checked. All the tests are passed. You can review it and let me know if there are any changes needed.

tests/fixtures/HLS-VI_stac_item.json Outdated Show resolved Hide resolved
hls_vi/generate_stac_items.py Outdated Show resolved Hide resolved
hls_vi/generate_stac_items.py Outdated Show resolved Hide resolved
hls_vi/generate_stac_items.py Outdated Show resolved Hide resolved
hls_vi/generate_stac_items.py Outdated Show resolved Hide resolved
hls_vi/generate_stac_items.py Outdated Show resolved Hide resolved
hls_vi/generate_stac_items.py Outdated Show resolved Hide resolved
tests/test_vi.py Outdated Show resolved Hide resolved
hls_vi/generate_stac_items.py Show resolved Hide resolved
hls_vi/generate_stac_items.py Outdated Show resolved Hide resolved
Co-authored-by: Chuck Daniels <[email protected]>
Copy link
Collaborator

@chuckwondo chuckwondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@madhuksridhar
Copy link
Collaborator

@chuckwondo @SwordSaintLancelot , received href for VI from LP:

I believe the correct URL should look like this for VI: https://data.lpdaac.earthdatacloud.nasa.gov/lp-prod-public/HLSL30_VI.020/ HLS-VI.S30.T47UNU.2024046T042851.v2.0/ HLS-VI.S30.T47UNU.2024046T042851.v2.0_stac.json

@SwordSaintLancelot
Copy link
Collaborator Author

I will update this URL in the code and push the changes.

@chuckwondo
Copy link
Collaborator

I will update this URL in the code and push the changes.

You can update your branch with your open PR since we haven't merged it yet.

@chuckwondo chuckwondo merged commit c3e69aa into main Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants