-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a STAC item for HLS_VI granules #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some unit tests and also expose an entry point for the command line (see https://github.com/NASA-IMPACT/hls-vi/blob/main/setup.py#L15-L20)
@SwordSaintLancelot, please fix these flake8 errors: https://github.com/NASA-IMPACT/hls-vi/actions/runs/9981613539/job/27585616075?pr=21 |
@SwordSaintLancelot, you can run linting and test locally by running the following, as mentioned in the README.md:
That should show you the same errors as the CI build, so you can address them locally before pushing your changes. |
You must also add missing dependencies to the |
@chuckwondo The code has been updated and checked. All the tests are passed. You can review it and let me know if there are any changes needed. |
Co-authored-by: Chuck Daniels <[email protected]>
Co-authored-by: Chuck Daniels <[email protected]>
Co-authored-by: Chuck Daniels <[email protected]>
Co-authored-by: Chuck Daniels <[email protected]>
Co-authored-by: Chuck Daniels <[email protected]>
Co-authored-by: Chuck Daniels <[email protected]>
Co-authored-by: Chuck Daniels <[email protected]>
Co-authored-by: Chuck Daniels <[email protected]>
Co-authored-by: Chuck Daniels <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@chuckwondo @SwordSaintLancelot , received I believe the correct URL should look like this for VI: https://data.lpdaac.earthdatacloud.nasa.gov/lp-prod-public/HLSL30_VI.020/ HLS-VI.S30.T47UNU.2024046T042851.v2.0/ HLS-VI.S30.T47UNU.2024046T042851.v2.0_stac.json |
I will update this URL in the code and push the changes. |
You can update your branch with your open PR since we haven't merged it yet. |
PR is created to create an STAC item for the HLS_VI granule.
Script description
generate_stac_items.py
is the script that generates a STAC item for the HLS_VI granule.In order to create the item, the script requires the
cmr xml
file of the HLS_VI granule along with the file name that should contain the STAC item in JSON format. It also requires theDAAC
information from where the data is being fetched.Other arguments and information are provided within the script in the form of function descriptions and arguments.