-
Notifications
You must be signed in to change notification settings - Fork 148
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[CLEANUP] Extract CSSFunction methods parseName and parseArguments
Also - Update the `parse` function signature to use PHP7 type hints; - Remove subsequently redundant DocBlock entries; - Ditto for same-named method in subclasses to avoid contravariance. Unfortunately, there seems to be a bug in PHP 7.3 (and 7.2) whereby it doesn't recognize a specific class name as a more-specific type than `object`, even though it does recognize it as more specific than an untyped return value. Thus some more-specific type annotations have had to be downgraded. This is the refactoring change from #390.
- Loading branch information
Jake Hotson
committed
Jun 21, 2024
1 parent
5a4245f
commit 1648cc7
Showing
3 changed files
with
32 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters