Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve discoverability of document search facets #992

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

allanlasser
Copy link
Member

@allanlasser allanlasser commented Jan 6, 2025

Resolves #304
Resolves #55

This improves discoverability of faceted search by providing users with menus to select field values to filter against and sort/order by properties.

To-Do

  • Sort menu
  • Filter menu
  • Serialize text query, filter, and sort parameters into a Solr-compatible search query
  • Deserialize Solr search queries into search toolbar props
  • Create document search component that serializes/deserializes between the URL query param and the search/filter/sort components
  • Improve deserialization to handle slugs in filters and + - requirement setting
  • Apply search filter during page render (right now it's client-only)
  • Update document search component to support small screen sizes

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for documentcloud-frontend-next ready!

Name Link
🔨 Latest commit e598635
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend-next/deploys/67856a3cf1e1d70008fe4085
😎 Deploy Preview https://deploy-preview-992.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 28 (🔴 down 22 from production)
Accessibility: 87 (🟢 up 1 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 92 (🟢 up 9 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 6, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 32.98% 8082 / 24505
🔵 Statements 32.98% 8082 / 24505
🔵 Functions 47.54% 339 / 713
🔵 Branches 75.6% 1153 / 1525
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/api/accounts.ts 86.62% 100% 88.23% 86.62% 201-228
src/lib/components/common/Menu.svelte 100% 100% 100% 100%
src/lib/components/documents/Filter.svelte 100% 15.38% 100% 100%
src/lib/components/documents/Search.svelte 100% 100% 100% 100%
src/lib/components/documents/Sort.svelte 100% 58.33% 100% 100%
src/lib/components/documents/tests/Filter.test.ts 100% 100% 100% 100%
src/lib/components/documents/tests/Search.test.ts 100% 100% 100% 100%
src/lib/components/documents/tests/Sort.test.ts 100% 100% 100% 100%
src/lib/components/forms/Search.svelte 0% 0% 0% 0% 1-43
src/lib/components/inputs/KeyValue.svelte 0% 0% 0% 0% 1-121
src/lib/components/inputs/Search.svelte 100% 100% 100% 100%
src/lib/components/inputs/Select.svelte 100% 100% 100% 100%
src/lib/components/layouts/DocumentBrowser.svelte 0% 0% 0% 0% 1-2527
src/lib/components/layouts/DocumentListToolbar.svelte 0% 0% 0% 0% 1-32
src/lib/utils/search.ts 86.27% 81.25% 77.77% 86.27% 27-28, 89-93
src/lib/utils/tests/search.test.ts 100% 100% 100% 100%
Generated in workflow #561 for commit e598635 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants