Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that we're in the browser before calling searchWithin #986

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

eyeseast
Copy link
Collaborator

Was getting a warning about eagerly calling fetch.

@eyeseast eyeseast requested a review from allanlasser December 17, 2024 18:49
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for documentcloud-frontend-next ready!

Name Link
🔨 Latest commit 813d2ed
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend-next/deploys/6761c7c26770830008970923
😎 Deploy Preview https://deploy-preview-986.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 22 (🔴 down 28 from production)
Accessibility: 87 (🟢 up 1 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 31.84% 7674 / 24098
🔵 Statements 31.84% 7674 / 24098
🔵 Functions 47.74% 339 / 710
🔵 Branches 75.71% 1113 / 1470
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/viewer/PaginationToolbar.svelte 0% 0% 0% 0% 1-1810
src/lib/components/viewer/Search.svelte 0% 0% 0% 0% 1-91
Generated in workflow #528 for commit 813d2ed by the Vitest Coverage Report Action

@eyeseast eyeseast merged commit b23f88c into main Dec 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants