Prevent calls to getMe from embed
#417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanlasser
force-pushed
the
fix/getMe-too-many-calls
branch
from
0161ef2 to
cee4bf4
Compare
✅ Deploy Preview for documentcloud-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for documentcloud-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Reintroduces CSRF cookie check in `getMe` API call
allanlasser
force-pushed
the
fix/getMe-too-many-calls
branch
from
cee4bf4 to
396b266
Compare
Coverage report
Test suite run success75 tests passing in 15 suites. Report generated by 🧪jest coverage report action from f8a976a |
eyeseast
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change removed the CSRF token check during the call to the
getMeAPI handler. This led to increased unauthenticated calls to getMe from the embedded viewer. This reintroduces that check and should minimize unnecessary requests to the endpoint.