Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension reload script #76

Closed
wants to merge 1 commit into from

Conversation

nbiscaro
Copy link
Contributor

@nbiscaro nbiscaro commented Jan 7, 2025

Automate the process of reloading the extension by:

  • Building the extension with make debug
  • Installing the extension
  • Restarting PG
  • Dropping the extension
  • Creating the extension

Example usage:

./scripts/reload-extension.sh

Found this useful so thought I would share. Any other workflow automations can also be added here.

@dpxcc
Copy link
Contributor

dpxcc commented Jan 7, 2025

Why do we need to restart Postgres in order to reload extension?
I usually just make debug -j8 && make install then DROP EXTENSION pg_mooncake CASCADE; CREATE EXTENSION pg_mooncake

@nbiscaro
Copy link
Contributor Author

nbiscaro commented Jan 8, 2025

Why do we need to restart Postgres in order to reload extension? I usually just make debug -j8 && make install then DROP EXTENSION pg_mooncake CASCADE; CREATE EXTENSION pg_mooncake

Restarting Postgres is not strictly necessary in most cases, but it ensures there are no lingering issues or edge cases. Since restarting is quick and retains session history, it’s a cautious approach with minimal downside.

@dpxcc dpxcc force-pushed the main branch 3 times, most recently from 64a3e22 to 6a655ea Compare January 15, 2025 22:11
@dpxcc
Copy link
Contributor

dpxcc commented Jan 20, 2025

Hi, I don't see an immediate need for this script. Let's defer the diff for now, and revisit it in the future when the process becomes more complex. At that point, a script like this might be useful

@nbiscaro nbiscaro closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants