Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Qt-created 'cache' directory #1962

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Ignore Qt-created 'cache' directory #1962

merged 1 commit into from
Jan 1, 2024

Conversation

ashemedai
Copy link
Contributor

Ignore Qt-created 'cache' directory, which currently pops up in the instance overview window.

@ashemedai
Copy link
Contributor Author

Just to make sure this is recorded here:

  • @qudix removed this two years ago, curious if there was a particular reason for that
  • isanae added this and qtwebengine 4 years ago, but at that point we were using Qt 5. Could it be that qtwebengine can be removed with Qt 6.5 we are using? I have seen no recorded cases on my installation. I did, however, see cache in the instance overview.

@qudix
Copy link
Contributor

qudix commented Dec 31, 2023

Because I assumed I fixed what was causing the cache folder to be generated there. Of course I think I remember changing my mind about removing it from the ignore list after the fact.

@qudix
Copy link
Contributor

qudix commented Dec 31, 2023

Ideally I feel like we really should be checking for the existence of a ModOrganizer.ini instead of just treating any folder as an instance.

@ashemedai
Copy link
Contributor Author

Ideally I feel like we really should be checking for the existence of a ModOrganizer.ini instead of just treating any folder as an instance.

Ah, that's a good one. Might give that a crack tomorrow.

@ashemedai
Copy link
Contributor Author

The cache folder gets recreated when I go to Nexus Info from the mod's information window. If I delete that directory with an actively running MO2, I get the following in the log until I fully restart MO2:

[2024-01-01 08:23:42.715 W] Got unexpected locking error 3
[2024-01-01 08:23:42.715 W] Could not create pipeline cache lock file 'C:/Users/USERNAME/AppData/Local/ModOrganizer/cache/qtpipelinecache-x86_64-little_endian-llp64/qqpc_opengl.lck'

@Holt59 Holt59 merged commit 5adb1ec into ModOrganizer2:master Jan 1, 2024
2 checks passed
@ashemedai ashemedai deleted the ignore_cache_instance branch January 1, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants