Bug fix/some bugs #171
Merged
Bug fix/some bugs #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates at least one warning Switched off fullscreen, this fixes MobileOrg#168
Triggered by MobileOrg#169 Also added status code. New Dropbox API does not have http status codes anymore. This could lead to some misbehaviour of state machine.
authentication challenge logic was not handled correctly http redirection still not handled error handling was missing in new webdavtransfermanager
webframp
reviewed
Feb 3, 2017
| @@ -753,6 +753,19 @@ - (void)transferComplete:(TransferContext*)context { | |||
|
|
|||
| - (void)transferFailed:(TransferContext*)context { | |||
| //NSLog(@"Failed %@ with code %d", [context remoteUrl], [context statusCode]); | |||
|
|
|||
| switch ([context statusCode] ) { | |||
webframp
reviewed
Feb 3, 2017
| NSURLCredential *credential = [NSURLCredential credentialForTrust:challenge.protectionSpace.serverTrust]; | ||
| [challenge.sender useCredential:credential forAuthenticationChallenge:challenge]; | ||
|
|
||
| UIAlertController *alertController = [UIAlertController alertControllerWithTitle:@"SSL Handshake" message:@"Server Ceritificate could not be validated.\nWould you like to continiue?" preferredStyle:UIAlertControllerStyleAlert]; |
This was referenced Feb 4, 2017
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebDAVTransferManager is now in Swift
Only Core Data
deletedattribute remains as warningSide-effects of #167 and #169 should be tackled completely
http redirection is not implemented and tested because I do miss a test-environment for that. Nevertheless if there are no other errors I would propose this for beta-test (with the request to give immediate feedback 😉 )