Skip to content

Commit

Permalink
Fix how the test host app is made into a .app (#529)
Browse files Browse the repository at this point in the history
In the previous was we would `rstrip` the test_host's app extension. If this happened to be the same as the end of the app name it would strip that too.
For example if it was `Foo-App.app` it would change to `Foo-A.app`.

This updates to take whatever is before the app extension by splitting the test_host's extension + '.' and taking the first entry.

Signed-off-by: dostrander <[email protected]>
  • Loading branch information
dostrander authored Feb 20, 2022
1 parent bc8c924 commit 8c1b923
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions bptestrunner/bluepill_batch_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ def _bluepill_batch_test_impl(ctx):

#test_plan
test_plan = struct(
test_host = test_host.basename.rstrip(
test_host = test_host.basename.split(
"." + test_host.extension,
) + ".app",
)[0] + ".app",
environment = test_env,
arguments = test_env,
test_bundle_path = bundle_info.bundle_name + bundle_info.bundle_extension,
Expand Down

0 comments on commit 8c1b923

Please sign in to comment.