Update railtie to install after known dependencies #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sure, looks fine thank you 👍 |
SamSaffron
added a commit
that referenced
this pull request
Oct 29, 2013
Update railtie to install after known dependencies
|
@jerryclinesmith sorry, I have to revert this, it is completely broken on rails 4 without any trivial fixes. |
|
No problem, I'll spin it up in 4 and see If I can figure something out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an issue deploying to Heroku and found this open issue on the old repo: SamSaffron/MiniProfiler#131
I noticed you were open to taking a patch for this, so here it is. I'd be happy to add tests for it, but couldn't really think of how, if you have any ideas let me know.