Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing custom headers on core api charge #32

Conversation

rizdaprasetya
Copy link
Collaborator

@rizdaprasetya rizdaprasetya commented Oct 18, 2023

Issue

response_dict, response_object = self.http_client.request(
'post',
self.api_config.server_key,
api_url,
parameters)

Specific for CoreApi’s charge func is missing to implement params:

     self.api_config.custom_headers,
     self.api_config.proxies

For example, the expected full params:

response_dict, response_object = self.http_client.request(
'post',
self.api_config.server_key,
api_url,
parameters,
self.api_config.custom_headers,
self.api_config.proxies)

Impact:

  • causing self.api_config.custom_headers to be unexpectedly ignored (not used).

(Issue as reported in Pilar Halp tix #3378)

@rizdaprasetya rizdaprasetya added the hacktoberfest-accepted Accepted PR for hacktoberfest participant label Oct 18, 2023
@rizdaprasetya rizdaprasetya merged commit 72883f5 into Midtrans:master Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted PR for hacktoberfest participant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant