Fix missing custom headers on core api charge #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
midtrans-python-client/midtransclient/core_api.py
Lines 39 to 43 in 49cb73c
Specific for CoreApi’s
charge
func is missing to implement params:For example, the expected full params:
midtrans-python-client/midtransclient/core_api.py
Lines 58 to 64 in 49cb73c
Impact:
self.api_config.custom_headers
to be unexpectedly ignored (not used).(Issue as reported in Pilar Halp tix #3378)