-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UPD] Remove exposed Key, Add version Param, Deprecated support for python 2 #20
Conversation
Thanks for the quick PR! Mostly looks good, we'll be reviewing this in-depth sometimes on next weekday. Some quick comments:
It is actually intentional for the keys to be hardcoded, so that:
We'll be back soon to further review & merge, thanks! |
I see, I thought it is a mistakes, There are no explanation why the key are there to begin with. |
This reverts commit 6215c4e. It is actually intentional for the keys to be hardcoded, so that: - example flask app can be easily run without requiring people to sign up first, it is good for demonstration purpose. - test result can be consistent and centralized to one test account So it is fine to leave the keys exposed. We acknowledge & are ok with the risk. It is also just a sandbox env key with no major potential harm (which anyway we can block anytime from our side if we need to).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the PR looks good 👍 thanks! I reverted the API keys removal, fixed test, and added some notes to improve this PR. Should be good now.
We'll merge this now (but not release it yet, we'll release together with that 1 other PR about Python 2 compatibility). Thanks for your contribution @mashanz ! Appreciate your solid works! 😃
Thanks @rizdaprasetya 🔥🎉👍🏻 |
This PR will fix view issue here:
midtransclient.__version__
to check this modul version for better version control & integration or backward compatibility.