Proposal: Add microsoft/msbuild image #492

StefanScherer · 2016-11-20T08:14:44Z

Here is a Dockerfile to build a Docker image with the Visual Studio C++ Build tools installed.
It would be great if we have something like FROM microsoft/vcbuildtools:14.3 to run msbuild in a Container very easily.

How to use this image

Build the image

docker build -t microsoft/vcbuildtools:14.3 .

Use the image

Go into a folder with a simple C++ or other project with a solution file *.sln.

docker run -v "$(pwd):C:\code" microsoft/vcbuildtools:14.3 msbuild yourproject.sln /p:Configuration=Release

Example:

git clone https://github.com/StefanScherer/win-getaddrinfo
cd win-getaddrinfo
docker run -v "$(pwd):C:\code" microsoft/vcbuildtools:14.3 msbuild getaddrinfo.sln /p:Configuration=Release
dir getaddrinfo.exe

StefanScherer · 2016-11-20T09:06:42Z

windows-container-samples/msbuild/Dockerfile

+
+WORKDIR /code
+
+ENTRYPOINT ["C:\\entrypoint.bat"]


Lost and found. Perhaps instead of using this entrypoint.bat we should burn in all environments as done here: https://github.com/friism/hello-world/blob/32b486472ebcd64fd26b0264dc988958bf44ccf5/windows/Dockerfile.build#L14-L19

If the c++ toolchain really likes to be run in cmd and users are used to interacting with it using the "Visual Studio developer prompt", then I think sticking to cmd is good. But it also seems like MS is moving towards Powershell: http://news.softpedia.com/news/microsoft-replaces-command-prompt-with-powershell-in-latest-windows-10-build-510328.shtml

Good point. I also prefer your solution setting all environment variables. I found the problem with some of the variables. If a value ends with a backslash \ then it is stored with a double quote " instead. Eg. for the environment variable WindowsSdkDir.

Replacing the

setx /M $v[0] $v[1]

command with

[Environment]::SetEnvironmentVariable($v[0], $v[1], [EnvironmentVariableTarget]::Machine);

it works fine. I'll update this PR to get rid of the entrypoint.bat.

StefanScherer · 2016-11-20T18:43:30Z

Removed the entryoint.bat script.

PatrickLang · 2016-11-28T20:08:40Z

windows-container-samples/msbuild/README.md

+# msbuild
+
+Build a Docker image with Visual C++ Build tools.
+The `entrypoint.bat` script calls the `vcbuildtools.bat` script to set all


I don't see those scripts. Are they still needed?

The entrypoint is no longer needed, I'll update the readme.

PatrickLang · 2016-11-28T20:09:45Z

Thanks for submitting this! I'm trying to see if anyone from the MSBuild team wants to review it. It looks good to me, so if they don't have any feedback I'll get it merged.

StefanScherer · 2016-11-28T22:48:41Z

Updated the README.md.

rainersigwald

[I'm an MSBuild maintainer]

We don't currently have a Docker image, nor plans to create one, though @alexellis proposed one: dotnet/msbuild#1140.

Since this isn't just MSBuild I'd rather the name be something like vcbuildtools.

C# builds are likely to fail without some .NET Targeting Packs installed. Since you're aiming at C++ builds this might not be the place for it.

rainersigwald · 2016-11-29T19:51:17Z

windows-container-samples/msbuild/Dockerfile

+
+SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop';"]
+
+RUN (New-Object System.Net.WebClient).DownloadFile('http://download.microsoft.com/download/5/f/7/5f7acaeb-8363-451f-9425-68a90f98b238/visualcppbuildtools_full.exe', 'visualcppbuildtools_full.exe') ; \


This is the "with Update 3" installer, right? (It appears to be, just double-checking.)

@StefanScherer why not just use Invoke-WebRequest

@friism After changing the SHELL line to

SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]

I can switch back to Invoke-WebRequest to have the same download rate.

Did you have another commit with that change? I want to get this merged but wasn't sure if you were going to switch back to Invoke-WebRequest or not

Thanks for the reminder. Updating right now and testing the build again...

rainersigwald · 2016-11-29T19:58:56Z

windows-container-samples/msbuild/README.md

+## Build image
+
+```
+docker build -t msbuild .


Specify a version? vcbuildtools:14.3?

PatrickLang · 2016-11-29T21:41:50Z

Thanks @rainersigwald . I think vcbuildtools would be a better name as well.

friism

Should probably make clear that this is 64bit toolchain. As @rainersigwald suggested, it might also be worth parametrizing the VS version to 14

friism · 2016-11-29T21:39:59Z

windows-container-samples/msbuild/Dockerfile

+
+SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop';"]
+
+RUN (New-Object System.Net.WebClient).DownloadFile('http://download.microsoft.com/download/5/f/7/5f7acaeb-8363-451f-9425-68a90f98b238/visualcppbuildtools_full.exe', 'visualcppbuildtools_full.exe') ; \


@StefanScherer why not just use Invoke-WebRequest

friism · 2016-11-29T22:07:05Z

This (now obsolete) PR has details on how something like this might be used: docker-library/hello-world#22

Signed-off-by: Stefan Scherer <[email protected]>

StefanScherer · 2016-12-08T20:12:53Z

@PatrickLang Updated the PR and changed it to master branch. Can't remember why I opened this to live branch directly.

PatrickLang · 2016-12-08T20:20:59Z

live branch is actually preferred now but either work. We changed the default to live.

rs38 · 2016-12-13T08:16:06Z

building without testing (at least unit test level) is quite pointless in nowadays devops tool chains. :)
is anyone of you aware of an image providing mstest / vstest? (not v2).
further questions would lead me to execution of web performance tests, which is very out of scope in this issue, any idea where to place?

Added custom path option to CredSpec docs

StefanScherer mentioned this pull request Nov 20, 2016

Add msbuild image to compile some C++ solutions StefanScherer/dockerfiles-windows#25

Merged

StefanScherer commented Nov 20, 2016

View reviewed changes

StefanScherer force-pushed the add-msbuild-image branch from d72b8d8 to d3a97cf Compare November 20, 2016 18:42

PatrickLang self-assigned this Nov 28, 2016

PatrickLang reviewed Nov 28, 2016

View reviewed changes

StefanScherer force-pushed the add-msbuild-image branch from d3a97cf to 8f2882f Compare November 28, 2016 22:47

rainersigwald approved these changes Nov 29, 2016

View reviewed changes

friism reviewed Nov 29, 2016

View reviewed changes

PatrickLang added the Windows Containers label Nov 30, 2016

Add vcbuildtools image

7b49862

Signed-off-by: Stefan Scherer <[email protected]>

StefanScherer force-pushed the add-msbuild-image branch from 8f2882f to 7b49862 Compare December 8, 2016 20:07

StefanScherer changed the base branch from live to master December 8, 2016 20:11

PatrickLang merged commit 0252ceb into MicrosoftDocs:master Dec 8, 2016

StefanScherer deleted the add-msbuild-image branch December 14, 2016 17:13

opbld15 pushed a commit that referenced this pull request Jan 3, 2020

Merge pull request #492 from MicrosoftDocs/ryanpu-credspec

cde1647

Added custom path option to CredSpec docs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proposal: Add microsoft/msbuild image #492

Proposal: Add microsoft/msbuild image #492

StefanScherer commented Nov 20, 2016 •

edited

Loading

StefanScherer Nov 20, 2016

friism Nov 20, 2016

StefanScherer Nov 20, 2016 •

edited

Loading

StefanScherer commented Nov 20, 2016

PatrickLang Nov 28, 2016

StefanScherer Nov 28, 2016

PatrickLang commented Nov 28, 2016

StefanScherer commented Nov 28, 2016

rainersigwald left a comment

rainersigwald Nov 29, 2016

friism Nov 29, 2016

StefanScherer Dec 1, 2016

PatrickLang Dec 8, 2016

StefanScherer Dec 8, 2016

rainersigwald Nov 29, 2016

StefanScherer Dec 8, 2016

PatrickLang commented Nov 29, 2016

friism left a comment

friism Nov 29, 2016

friism commented Nov 29, 2016

StefanScherer commented Dec 8, 2016

PatrickLang commented Dec 8, 2016

rs38 commented Dec 13, 2016


		SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop';"]

		RUN (New-Object System.Net.WebClient).DownloadFile('http://download.microsoft.com/download/5/f/7/5f7acaeb-8363-451f-9425-68a90f98b238/visualcppbuildtools_full.exe', 'visualcppbuildtools_full.exe') ; \


		WORKDIR /code

		ENTRYPOINT ["C:\\entrypoint.bat"]

Proposal: Add microsoft/msbuild image #492

Proposal: Add microsoft/msbuild image #492

Conversation

StefanScherer commented Nov 20, 2016 • edited Loading

Build the image

Use the image

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StefanScherer Nov 20, 2016 • edited Loading

Choose a reason for hiding this comment

StefanScherer commented Nov 20, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PatrickLang commented Nov 28, 2016

StefanScherer commented Nov 28, 2016

rainersigwald left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PatrickLang commented Nov 29, 2016

friism left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

friism commented Nov 29, 2016

StefanScherer commented Dec 8, 2016

PatrickLang commented Dec 8, 2016

rs38 commented Dec 13, 2016

StefanScherer commented Nov 20, 2016 •

edited

Loading

StefanScherer Nov 20, 2016 •

edited

Loading