Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: @metamask/eth-json-rpc-engine@^7.1.1->^8.0.1 #306

Merged
merged 7 commits into from
Jun 6, 2024
Merged

deps: @metamask/eth-json-rpc-engine@^7.1.1->^8.0.1 #306

merged 7 commits into from
Jun 6, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 24, 2024 •
edited
Loading

  • deps: @metamask/eth-json-rpc-provider@^2.1.0->^3.0.2
  • deps: @metamask/eth-json-rpc-engine@^7.1.1->^8.0.1
  • deps: @metamask/eth-block-tracker@^9.0.2->^9.0.3

Blocked by

dependabot bot and others added 3 commits March 18, 2024 06:36
@dependabot
Bump @metamask/json-rpc-engine from 7.3.1 to 8.0.1
22a74d9 
Bumps [@metamask/json-rpc-engine](https://github.com/MetaMask/core) from 7.3.1 to 8.0.1.
- [Release notes](https://github.com/MetaMask/core/releases)
- [Changelog](https://github.com/MetaMask/core/blob/main/docs/reviewing-release-prs.md)
- [Commits](https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected])

---
updated-dependencies:
- dependency-name: "@metamask/json-rpc-engine"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@legobeat
Merge branch 'main' into dependabot/npm_and_yarn/main/metamask/json-r…
235a32d 
…pc-engine-8.0.1
@legobeat
deps: @metamask/eth-json-rpc-provider@^2.1.0->^3.0.2
409a5c4
@legobeat legobeat mentioned this pull request May 24, 2024
Closed
@socket-security Socket Security
Copy link

socket-security bot commented May 24, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

@legobeat legobeat added the dependencies Pull requests that update a dependency file label May 24, 2024
legobeat and others added 3 commits May 27, 2024 04:18
@legobeat
deps: @metamask/json-rpc-engine@^7.1.1->^8.0.2
1a77ba9 
- deps: @metamask/eth-json-rpc-provider@^2.1.0->^3.0.2
- deps: @metamask/eth-block-tracker@^9.0.2->^9.0.3
@legobeat
deps: @metamask/eth-block-tracker@^9.0.2->^9.0.3
c51b316
@legobeat
Merge branch 'main' into deps-json-rpc-engine-8
208344a
@legobeat legobeat marked this pull request as ready for review May 28, 2024 18:23
@legobeat legobeat requested a review from a team as a code owner May 28, 2024 18:23
@legobeat legobeat requested a review from dbrans May 29, 2024 12:41
@dbrans
Copy link

dbrans commented May 31, 2024

Hi @legobeat. Does this change require a version bump to this package? I'm not familiar with how this should work.

@legobeat
Copy link
Contributor Author

legobeat commented May 31, 2024 •
edited
Loading

Hi @legobeat. Does this change require a version bump to this package? I'm not familiar with how this should work.

The changelogs for packages with breaking versions:

https://github.com/MetaMask/core/blob/main/packages/json-rpc-engine/CHANGELOG.md

https://github.com/MetaMask/core/blob/main/packages/eth-json-rpc-provider/CHANGELOG.md

From my perspective arbitrary if this goes into 12.1.1 or 12.2.0, but in any case should not be breaking (requiring a 13.0.0) AIUI. But as always, don't take my word for it being good ;)

@Mrtenz Mrtenz removed their request for review June 4, 2024 19:36
rekmarks
rekmarks approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything here that could count as a breaking change for consumers of this package.

mcmire
mcmire approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, LGTM!

@legobeat legobeat merged commit 1d61dc8 into MetaMask:main Jun 6, 2024
19 checks passed
@legobeat legobeat mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks approved these changes

@dbrans dbrans dbrans approved these changes

@mcmire mcmire mcmire approved these changes

@matthewwalsh0 matthewwalsh0 Awaiting requested review from matthewwalsh0

@kumavis kumavis Awaiting requested review from kumavis

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legobeat @dbrans @mcmire @rekmarks