fix: Network controller race condition after state update

[bergeron]

Explanation

Fixes a race condition where:

• You update a network with a new endpoint.
• In the stateChange subscription callback, call getNetworkConfigurationByNetworkClientId on the new endpoint.
• It returns undefined.

This occurs because the network client id -> network configuration map was being built after the state update, so it was not ready at the time of the stateChange event.

The fix involves moving this map building inside the state update, so that its built by the time stateChange fires. But also requires deep cloning the state before building the map from it. Otherwise we get Cannot perform 'get' on a proxy that has been revoked when referencing the ephemeral state lambda.

References

Changelog

@metamask/network-controller

• FIXED: A race condition when calling getNetworkConfigurationByNetworkClientId in response to a stateChange event adding a new endpoint to a network.

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes