Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match signature request and message params ID #5102

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

matthewwalsh0
Copy link
Member

Explanation

Ensure the signature request id and message params metamaskId use the same value so that legacy code using only the message params can locate the associated signature request.

References

Changelog

@metamask/signature-controller

  • FIXED: Use same value for signature request id and message params metamaskId.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthewwalsh0 matthewwalsh0 enabled auto-merge (squash) January 6, 2025 15:04
@matthewwalsh0 matthewwalsh0 merged commit 3bd40d3 into main Jan 6, 2025
120 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/match-signature-request-params-id branch January 6, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants