Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update token image for Prosper (PROS) #1398

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

prosper-fi
Copy link
Contributor

Directed by MetaMask support team to submit a PR here to update the token image that currently shows up on MetaMask for the PROS token.

The token is on both Ethereum and BSC. This PR updates the image and adds an entry for the ETH contract address.

Project website here: https://www.prosper-fi.com/

CoinGecko link here: https://www.coingecko.com/en/coins/prosper

Etherscan link here: https://etherscan.io/address/0x8642a849d0dcb7a15a974794668adcfbe4794b56

Thank you for your help! Please let us know if you have any questions.

Directed by MetaMask support team to submit a PR here to update the token image that currently shows up on MetaMask for the PROS token.

The token is on both Ethereum and BSC.

Project website here: https://www.prosper-fi.com/

CoinGecko link here: https://www.coingecko.com/en/coins/prosper

Etherscan link here: https://etherscan.io/address/0x8642a849d0dcb7a15a974794668adcfbe4794b56

BSCscan link here: https://bscscan.com/address/0xed8c8aa8299c10f067496bb66f8cc7fb338a3405
@prosper-fi prosper-fi requested review from MRabenda and a team as code owners December 3, 2024 11:25
@prosper-fi
Copy link
Contributor Author

@MRabenda Here is the ETH request per your comment on the other (now closed) PR.

Also, before we submit for BSC, could you please help confirm if we are supposed to follow the same procedure and add an entry to the same contract-map.json file but just with the BSC address? Or is it a different procedure?

@prosper-fi
Copy link
Contributor Author

@MRabenda just quickly following up on this. Thank you!

@MRabenda MRabenda merged commit be98014 into MetaMask:master Dec 6, 2024
7 checks passed
@prosper-fi
Copy link
Contributor Author

Thank you @MRabenda ! Could you please also confirm the procedure for updating BSC side as well?

@MRabenda
Copy link
Collaborator

MRabenda commented Dec 6, 2024

At this time that repo handles on Ethereum network - for BSC it will need to be added to three lists like:

uniswapLabs: 'https://gateway.ipfs.io/ipns/tokens.uniswap.org',
sushiswap: 'https://token-list.sushi.com/',
apeswap: 'https://raw.githubusercontent.com/ApeSwapFinance/apeswap-token-lists/main/lists/apeswap.json',

@prosper-fi
Copy link
Contributor Author

@MRabenda thank you! We'll work on getting the BSC version updated on those lists. Once that's done, what would be the next step to ensure that the token logo is updated on MetaMask?

Also, just following up on the ETH side—seems like the image has been updated, however, it's grayscale / B&W: https://static.cx.metamask.io/api/v1/tokenIcons/1/0x8642a849d0dcb7a15a974794668adcfbe4794b56.png. Could you please help fix?

@prosper-fi
Copy link
Contributor Author

Hi @MRabenda , could you please help advise on next steps for the BSC update (as well as the ETH side grayscale token image issue)?

On BSC side, PROS is already on several lists, including PancakeSwap, Rango, CoinGecko, and CoinMarketCap. In all of these cases, the token logo image is already updated to our latest token logo. How do we now ensure that MetaMask will also reflect the correct logo on BSC side?

Thank yoU!

@prosper-fi
Copy link
Contributor Author

Hi @MRabenda , just a quick follow-up on the above. Thanks!

@prosper-fi
Copy link
Contributor Author

Hi @MRabenda , happy new year! Just following up on our conversation above. Thanks!

@MRabenda
Copy link
Collaborator

Hey @prosper-fi - which MM version are you using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants