Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: 4207448: Remove the API requests URLs prefixes + issue: 4207454: Handle not found UFM version case #289

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

Miryam-Schwartz
Copy link
Contributor

What

Small improvements and fixes in log analyzer pdf.

Why ?

To improve the PDF's appearance and readability.

How ?

  1. Handle cases where the UFM version is not found.
  2. Remove API request URL prefixes.
  3. Add a legend title to the API requests graph.
  4. Update graph titles to make them clearer.

Testing ?

Manually reviewed the PDF output.

Special triggers

Use the following phrases as comments to trigger different runs

  • bot:retest rerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)
  • bot:upgrade run additional update tests

@drorlevy drorlevy merged commit e76cd85 into Mellanox:main Dec 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants