-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIDRPool 1/x] Add CIDRPool CRD definition and validation logic #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mostly nitpicks, some ideas as well.
87dc4ca
to
030420c
Compare
030420c
to
f975526
Compare
f975526
to
a1f10b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vasrem Thanks for the review. I think I addressed all your comments. Please, have another look on the PR when you have time.
a1f10b2
to
cc6ed19
Compare
cc6ed19
to
a67e27b
Compare
Signed-off-by: Yury Kulazhenkov <[email protected]>
a67e27b
to
bed2490
Compare
No description provided.