HWS: Improvements to binary file handling #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has 2 advantages: 1) Performance: fewer syscalls due to no longer repeatedly closing and reopening the same file 2) Exception safety, guaranteeing that this file will be closed at the end of the `with` clause Signed-off-by: Alexander Efimov <[email protected]>
We do not write to this file, so there is no reason to open it in `r+` (read + update) mode. Signed-off-by: Alexander Efimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HWS: Open the binary file in read-only mode
We do not write to this file, so there is no reason to open it
in
r+(read + update) mode.Signed-off-by: Alexander Efimov [email protected]
HWS: Keep the binary file open between each read
This has 2 advantages:
reopening the same file
end of the
withclauseSigned-off-by: Alexander Efimov [email protected]