Some cleanup #108
Open
Some cleanup #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the patches except "HWS: Defer prettifying actions" are ok, just please add "Signed-off-by:" to the commit message, and remove the dot at end of line from the title in the commit message |
|
@nv-aefimov Also thank you for contributing to our project! |
Change file permissions such that the scripts `mlx_steering_dump` and `mlx_hw_steering_dump` are user-executable. Signed-off-by: Alexander Efimov <[email protected]>
Signed-off-by: Alexander Efimov <[email protected]>
The file will automatically be closed at the end of the scope. This is safer and more pythonic. Signed-off-by: Alexander Efimov <[email protected]>
Use python's built-in pathlib instead of manipulating strings. Signed-off-by: Alexander Efimov <[email protected]>
nv-aefimov
force-pushed
the
minor-cleanup
branch
from
70a5c7c to
c58af21
Compare
|
Updated based on the comments. Please let me know if I should change anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up a few minor issues. No functional changes.