Tuning information about the DDR temperature sensor in the SDR repository (no change to functionality) #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he SDR repository. No reading or setting of lower critical and non-critical thresholds. Not initializing hysteresis. Not specifying nominal reading. Test: Before changes: # ipmitool -I ipmb sensor get ddr_temp Locating sensor record... Sensor ID : ddr_temp (0x9) Entity ID : 7.2 Sensor Type (Threshold) : Temperature Sensor Reading : 80 (+/- 0) degrees C Status : ok Lower Non-Recoverable : na Lower Critical : 0.000 Lower Non-Critical : 5.000 Upper Non-Critical : 95.000 Upper Critical : 105.000 Upper Non-Recoverable : na Positive Hysteresis : Unspecified Negative Hysteresis : Unspecified Assertions Enabled : lnc- lcr- unc+ ucr+ Deassertions Enabled : lnc- lcr- unc+ ucr+ After changes: # ipmitool -I ipmb sensor get ddr_temp Locating sensor record... Sensor ID : ddr_temp (0x9) Entity ID : 7.2 Sensor Type (Threshold) : Temperature Sensor Reading : 80 (+/- 0) degrees C Status : ok Lower Non-Recoverable : na Lower Critical : na Lower Non-Critical : na Upper Non-Critical : 95.000 Upper Critical : 105.000 Upper Non-Recoverable : na Positive Hysteresis : Unspecified Negative Hysteresis : Unspecified Assertions Enabled : unc+ ucr+ Deassertions Enabled : unc+ ucr+ Fixes jira https://redmine.mellanox.com/issues/4064333 Signed-off-by: Yuval Nissan <[email protected]>
|
Where is it being used? |
@AdiFogel this is a follow-up to the dev I committed to insert the DDR temperature sensor into the SDR list. It is a tuning of the parameters meant to reflect the true capabilities of this sensor. There is no change to the functionality we need to support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No reading or setting of lower critical and non-critical thresholds. Not initializing hysteresis. Not specifying nominal reading.
Test:
Before changes:
After changes:
Fixes jira https://
Signed-off-by: Yuval Nissan [email protected]