removing rule protocol info as this isn't in use - TODO squash

Mellanox · Dec 25, 2024 · c9c3905 · c9c3905
1 parent acee972
commit c9c3905
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 13 deletions.
diff --git a/src/vma/proto/rule_table_mgr.cpp b/src/vma/proto/rule_table_mgr.cpp
@@ -99,8 +99,6 @@ void rule_table_mgr::update_tbl()
 // return true if its not related to local or default table, false otherwise.
 bool rule_table_mgr::parse_entry(struct nl_object *nl_obj, void *p_val_context)
 {
-    int err = 0;
-
     rule_val *p_val = static_cast<rule_val *>(p_val_context);
     // Cast the generic nl_object to a specific route or rule object
     struct rtnl_rule *rule = reinterpret_cast<struct rtnl_rule *>(nl_obj);
@@ -110,14 +108,6 @@ bool rule_table_mgr::parse_entry(struct nl_object *nl_obj, void *p_val_context)
         return false;
     }
 
-    // Set rule properties in p_val using libnl getters
-    uint8_t protocol = 0;
-    err = rtnl_rule_get_protocol(rule, &protocol);
-    if (err < 0) {
-        throw_vma_exception("Failed to get rule protocol");
-    }
-
-    p_val->set_protocol(protocol);
     p_val->set_tos(rtnl_rule_get_dsfield(rule));
     p_val->set_table_id(table_id);
 

diff --git a/src/vma/proto/rule_val.cpp b/src/vma/proto/rule_val.cpp
@@ -46,7 +46,6 @@
 rule_val::rule_val()
     : cache_observer()
 {
-    m_protocol = 0;
     m_dst_addr = 0;
     m_src_addr = 0;
     memset(m_oif_name, 0, IFNAMSIZ * sizeof(char));

diff --git a/src/vma/proto/rule_val.h b/src/vma/proto/rule_val.h
@@ -50,7 +50,6 @@ class rule_val : public cache_observer {
 
     inline void set_dst_addr(in_addr_t const &dst_addr) { m_dst_addr = dst_addr; };
     inline void set_src_addr(in_addr_t const &src_addr) { m_src_addr = src_addr; };
-    inline void set_protocol(unsigned char protocol) { m_protocol = protocol; };
     inline void set_tos(unsigned char tos) { m_tos = tos; };
     inline void set_table_id(uint32_t table_id) { m_table_id = table_id; };
     inline void set_iif_name(char *iif_name) { memcpy(m_iif_name, iif_name, IFNAMSIZ); };
@@ -73,7 +72,6 @@ class rule_val : public cache_observer {
     char *to_str() { return m_str; };
 
 private:
-    unsigned char m_protocol;
     unsigned char m_tos;
 
     union {