Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Countdown in a pop-up window(ポップアップウインドウでのカウントダウン) #69

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

beatkz
Copy link

@beatkz beatkz commented Jan 24, 2022

以下のレビューを元にポップアップからカウントダウン機能を切り離し、ウインドウ上に複数メールのカウントダウンが出来るように実装してみました。

https://addons.thunderbird.net/ja/thunderbird/addon/confirm-address-5582/reviews/1168681/

投稿者: mtany - 1月 12, 2022 · 固定リンク

以前より長く使用しております。
誤送信や添付忘れなどのメール事故防止にとても有用なアドオンですが、できれば下記点を改善して頂きたいです。

あて先アドレス確認、チェック後「送信」ボタンを押してカウントダウンが始まりますが
現状ではその状態でメール作成画面が非アクティブになるとカウントダウンが止まり、メールが送信されません。
(以前は非アクティブになってもカウントダウンは継続されい、ゼロになるとメールが送信されていました)

カウントダウンの間は他のウィンドウをクリックしたら離別作業することもできず、ずっと待っていなければならないため
必然的にカウントダウンの設定秒数が短くなってしまいます。

理想としては1分くらいの設定にしておいて、その間にメール本文等の確認をして、問題無ければそのまま他の作業に移り、時間が来たら勝手に送信されている。という以前のバージョンの動きです。

ご検討宜しくお願いいたします。

Comment in English with DeepL Translation:

Based on the following review, I separated the countdown function from the popup and implemented it so that multiple emails can be counted down on the window.

https://addons.thunderbird.net/ja/thunderbird/addon/confirm-address-5582/reviews/1168681/

Submitted by mtany - January 12, 2022 - Fixed Link

I have been using it for a long time.
I've been using this add-on for a long time now, and it's very useful for preventing mishaps such as misdirected messages and forgotten attachments, but I'd like to see the following points improved.

The countdown starts when you click the "Send" button after checking and confirming the destination address.
However, if the compose screen becomes inactive, the countdown stops and the mail is not sent.
(Previously, the countdown continued even when the screen became inactive, and the email was sent when it reached zero.)

During the countdown, you can't click on another window and work separately, so you have to wait forever.
Inevitably, the number of seconds set for the countdown becomes shorter.

Ideally, I'd like to set the countdown time to about one minute, during which time I can check the body of the message, etc., and if there are no problems, I can move on to other tasks, and when the time comes, the message will be sent automatically. This is how the previous version worked.

Please consider this.

@beatkz beatkz marked this pull request as ready for review January 24, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant