Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7373: Include the FHIR Bundle returned from VSAC FHIR Term Service in the Value Set search response #94

Merged

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Jul 11, 2024

Terminology Service PR

Jira Ticket: MAT-7373
(Optional) Related Tickets:

Summary

Include the FHIR Bundle that comes back from VSAC's FHIR Terminology Service when searching for Value Sets in our search API's response. The entries of which will be displayed as value set "details" to the user when requested.

Note: The Bundle is returned as a String because the typed Bundle object is excessively huge when serialized to JSON as the FHIR Parser inits null/empty values by default.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner July 11, 2024 17:39
@jkotanchik-SB jkotanchik-SB self-assigned this Jul 11, 2024
@jkotanchik-SB jkotanchik-SB changed the title MAT-7373: Include the FHIR Bundle returned from VSAC FHIR Term Service in the Value Set search response. MAT-7373: Include the FHIR Bundle returned from VSAC FHIR Term Service in the Value Set search response Jul 11, 2024
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7373-return-vs-search-result-bundle branch from 1d52de3 to 65284d7 Compare July 11, 2024 17:43
…e in the Value Set search response.

Note: The Bundle is returned as a String because the typed Bundle object is excessively huge when serialized as it includes null/empty values by default.
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7373-return-vs-search-result-bundle branch from 65284d7 to f8c0212 Compare July 12, 2024 15:52
@jkotanchik-SB jkotanchik-SB merged commit b47cf36 into develop Jul 12, 2024
6 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-7373-return-vs-search-result-bundle branch July 12, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants