Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix group update issue for QDM strats that have no association #482

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

nmorasb
Copy link
Contributor

@nmorasb nmorasb commented Oct 18, 2023

MADiE PR

Jira Ticket: MAT-6306
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@nmorasb nmorasb requested a review from a team October 18, 2023 12:32
@nmorasb nmorasb marked this pull request as ready for review October 18, 2023 12:43
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #482 (043a62a) into develop (8c808c2) will increase coverage by 0.01%.
Report is 2 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #482      +/-   ##
===========================================
+ Coverage    95.31%   95.32%   +0.01%     
===========================================
  Files           88       88              
  Lines         2772     2781       +9     
  Branches       340      341       +1     
===========================================
+ Hits          2642     2651       +9     
  Misses          63       63              
  Partials        67       67              
Files Coverage Δ
...s/gov/madie/measure/resources/AdminController.java 100.00% <100.00%> (ø)
...a/cms/gov/madie/measure/services/GroupService.java 98.44% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nmorasb nmorasb merged commit 277b33d into develop Oct 18, 2023
5 checks passed
@nmorasb nmorasb deleted the feature/MAT-6306-fix-group-updates-qdm-testcases branch October 18, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants