Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAT-6187] Admin API to Hard Delete Measure Instance #479

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

jkotanchik-SB
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-6187
(Optional) Related Tickets:

Summary

Admin API to hard delete a single measure instance.

Accepts the Measure's object ID and deletes the instance, if found, from the document store.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner October 17, 2023 16:57
@jkotanchik-SB jkotanchik-SB requested a review from a team October 17, 2023 16:57
@jkotanchik-SB jkotanchik-SB self-assigned this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #479 (0db98d3) into develop (8c808c2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 0db98d3 differs from pull request most recent head 0b2cf81. Consider uploading reports for the commit 0b2cf81 to get more accurate results

@@             Coverage Diff             @@
##           develop     #479      +/-   ##
===========================================
+ Coverage    95.31%   95.32%   +0.01%     
===========================================
  Files           88       88              
  Lines         2772     2778       +6     
  Branches       340      341       +1     
===========================================
+ Hits          2642     2648       +6     
  Misses          63       63              
  Partials        67       67              
Files Coverage Δ
...s/gov/madie/measure/resources/AdminController.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jkotanchik-SB jkotanchik-SB changed the title [MAT-6187] Admin API to Hard Delete a Measure Instance [MAT-6187] Admin API to Hard Delete Measure Instance Oct 17, 2023
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-6187-admin-msr-delete branch from 89e926c to 0db98d3 Compare October 17, 2023 18:23
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-6187-admin-msr-delete branch from 0db98d3 to 0b2cf81 Compare October 18, 2023 13:24
@jkotanchik-SB jkotanchik-SB merged commit a927fb4 into develop Oct 18, 2023
2 of 3 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-6187-admin-msr-delete branch October 18, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants