Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAT-7966] Use DataRequirementsProcessor to build Data Requirements for Included Libraries #269

Merged

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Dec 4, 2024

MADiE FHIR SERVICE

Jira Ticket: MAT-7966
(Optional) Related Tickets:

Summary

Use Data Requirements Processor (DRP) to build Data Requirements for Included Libraries instead of creating them manually from the ANTLR parse of the CQL.

With the inclusion of US-Core and QI-Core Profiles, we need to use the DRP to properly typecast Profile based Types to their FHIR relative. The Parser is limited to the CQL text and will build Data Requirements such as "QICore Simple Observation" (instead of "Observation"), which will cause the downstream FHIR converter (R4 to R5) to error out.

Note: We have to perform the R4 to R5 conversion because we're using the R5 Liquid Engine to generate the Human Readable. The R4 Liquid Engine doesn't have the necessary support to process the provided Liquid templates.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner December 4, 2024 19:18
@jkotanchik-SB jkotanchik-SB self-assigned this Dec 4, 2024
…ments for Included Libraries instead of creating them manually from the ANTLR parse of the CQL.

The DRP typecasts Profile types to their FHIR ancestor. E.g. QICore Simple Observation will be typecast to Observation. This is needed for converting the FHIR Library from R4 to R5, which is needed to generate the HR with the R5 Liquid Engine.
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7966-qicore6-export-data-requirements branch from 80d13a5 to 0bfa915 Compare December 4, 2024 19:26
@jkotanchik-SB jkotanchik-SB merged commit a8f72a9 into develop Dec 4, 2024
5 checks passed
@jkotanchik-SB jkotanchik-SB changed the title [MAT-7966] Use DataRequirementsProcessor to build Data RRequirements for Included Libraries [MAT-7966] Use DataRequirementsProcessor to build Data Requirements for Included Libraries Dec 4, 2024
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-7966-qicore6-export-data-requirements branch December 4, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants