Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAT-6434: escaping additional fields on measure for human readable #178

Merged
merged 2 commits into from
Nov 16, 2023
Merged

MAT-6434: escaping additional fields on measure for human readable #178

merged 2 commits into from
Nov 16, 2023

Conversation

nmorasb
Copy link
Contributor

@nmorasb nmorasb commented Nov 16, 2023

MADiE FHIR SERVICE

Jira Ticket: MAT-6434
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@nmorasb nmorasb requested a review from a team November 16, 2023 03:32
@nmorasb nmorasb marked this pull request as ready for review November 16, 2023 04:21
@nmorasb nmorasb merged commit ece5044 into develop Nov 16, 2023
1 check passed
@nmorasb nmorasb deleted the feature/MAT-6434-escape-hr-fields branch November 16, 2023 13:13
adongare
adongare reviewed Nov 16, 2023
View reviewed changes
src/main/java/gov/cms/madie/madiefhirservice/services/HumanReadableService.java
measure.setSubtitle(escapeStr(measure.getSubtitle()));
measure.setRiskAdjustment(escapeStr(measure.getRiskAdjustment()));
measure.setRateAggregation(escapeStr(measure.getRateAggregation()));
measure.setClinicalRecommendationStatement(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be done on line 59?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adongare adongare adongare left review comments

@sb-cecilialiu sb-cecilialiu sb-cecilialiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmorasb @adongare @sb-cecilialiu