Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick pass on the index page, add CODEOWNERS #31

Merged
merged 5 commits into from
Mar 31, 2021
Merged

Quick pass on the index page, add CODEOWNERS #31

merged 5 commits into from
Mar 31, 2021

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Mar 28, 2021 •
edited by CasperWA
Loading

This PR refactors the index page of the website:

  • Remove random list of (previously) online databases
  • Add mention of providers dashboard
  • Add "Get Involved" section
    • Advertise meetings
    • Advertise workshop
    • Advertise mailing list
    • Advertise
  • Add a bunch of random people to CODEOWNERS so they get automatic review requests

This PR does not:

  • improve the wording of the intro paragraph that describes what OPTIMADE is, potentially separating the motivation section to a new page as suggested at The main landing text needs to be improved #9. It would be good if this could be added to the README of the specification too.

@ml-evs ml-evs added the enhancement New feature or request label Mar 28, 2021
@ml-evs ml-evs mentioned this pull request Mar 28, 2021
Merged
@ml-evs ml-evs force-pushed the ml-evs/add_meetings branch from 9db9079 to 5c1f5f7 Compare March 28, 2021 20:38
@ml-evs ml-evs marked this pull request as ready for review March 28, 2021 20:38
@ml-evs ml-evs changed the title Quick pass on the index page Quick pass on the index page, add CODEOWNERS Mar 28, 2021
CasperWA
CasperWA reviewed Mar 29, 2021
View reviewed changes
index.md Show resolved Hide resolved
CasperWA
CasperWA reviewed Mar 29, 2021
View reviewed changes
index.md Outdated Show resolved Hide resolved
@ml-evs ml-evs requested a review from CasperWA March 29, 2021 11:07
CasperWA
CasperWA approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion of a target addition, but can be left out.

index.md Show resolved Hide resolved
@ml-evs ml-evs merged commit ae9549e into master Mar 31, 2021
@CasperWA CasperWA deleted the ml-evs/add_meetings branch March 31, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA CasperWA approved these changes

@gmrigna gmrigna gmrigna approved these changes

@rartino rartino Awaiting requested review from rartino rartino is a code owner

@shyamd shyamd Awaiting requested review from shyamd

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ml-evs @gmrigna @CasperWA