OPTIMADE JSON Lines specification appendix #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
commented
Jul 28, 2024
ml-evs
commented
Jul 28, 2024
ml-evs
commented
Jul 28, 2024
ml-evs
commented
Jul 28, 2024
ml-evs
commented
Jul 28, 2024
ml-evs
commented
Jul 28, 2024
ml-evs
changed the title
Fix code block formatting Update optimade.rst Apply suggestions from code review Apply suggestions from code review Try to fix formatting again Fix formatting and add note about provider fields
ml-evs
force-pushed
the
ml-evs/jsonlines-draft
branch
from
6929f10 to
c5f1f53
Compare
ml-evs
force-pushed
the
ml-evs/jsonlines-draft
branch
from
96b0231 to
78e158c
Compare
Co-authored-by: Kristjan Eimre <[email protected]>
eimrek
reviewed
Aug 28, 2024
Co-authored-by: Kristjan Eimre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins the work on #471, by defining the conventions on top of JSON Lines for deserializing an entire OPTIMADE API into a file.