Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mzbuild: Don't ignore return code of docker push #31024

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

def-
Copy link
Contributor

@def- def- commented Jan 13, 2025

Proof that this works:

import subprocess
push = subprocess.Popen("ls asd | cat", shell=True)
print(push.wait()) # 0
push = subprocess.Popen("ls asd", shell=True)
print(push.wait()) # 2
push = subprocess.Popen(["/bin/bash", "-c", "set -o pipefail; ls asd | cat"])
print(push.wait()) # 2

Context: https://materializeinc.slack.com/archives/CM7ATT65S/p1736789270342329

Crazy that we never noticed this before! Dockerhub must be pretty reliable. I could not find another usage of us using this pattern in our code.

I'll remove the last commit before submitting.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Proof that this works:

    import subprocess
    push = subprocess.Popen("ls asd | cat", shell=True)
    print(push.wait()) # 0
    push = subprocess.Popen("ls asd", shell=True)
    print(push.wait()) # 2
    push = subprocess.Popen(["/bin/bash", "-c", "set -o pipefail; ls asd | cat"])
    print(push.wait()) # 2

Context: https://materializeinc.slack.com/archives/CM7ATT65S/p1736789270342329
@def- def- requested review from benesch and ParkMyCar January 13, 2025 17:55
@def- def- requested a review from a team as a code owner January 13, 2025 17:55
Copy link
Contributor

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@def- def- force-pushed the pr-docker-push branch 2 times, most recently from a70d3ad to 642df58 Compare January 13, 2025 18:24
@def- def- enabled auto-merge January 13, 2025 18:25
@def- def- merged commit 5fce976 into MaterializeInc:main Jan 13, 2025
74 checks passed
@def- def- deleted the pr-docker-push branch January 13, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants