Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a columnar implementation for Row #31022

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Provide a columnar implementation for Row #31022

wants to merge 1 commit into from
+149 −1

Conversation

antiguru
Copy link
Member

With no functional changes, this PR adds a Columnar implementation for Row. It's not used yet, but will be in subsequent changes. The implementation follows the String implementation in columnar, both types are very similar.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@antiguru
Provide a columnar implementation for Row
980b098 
With no functional changes, this PR adds a `Columnar` implementation for
`Row`. It's not used yet, but will be in subsequent changes. The
implementation follows the `String` implementation in columnar, both types
are very similar.

Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru antiguru requested a review from a team as a code owner January 13, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankmcsherry frankmcsherry Awaiting requested review from frankmcsherry

@teskje teskje Awaiting requested review from teskje

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@antiguru