Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: move methods from StorageController to StorageCollections #31019

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aljoscha
Copy link
Contributor

@aljoscha aljoscha commented Jan 13, 2025

Work towards implementing https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/20240117_decoupled_storage_controller.md. This design document is nice and small, and should help to explain the long-term motivations for those changes.

Prompted by a recent PR from @petrosagg (#30729), I went back to implement some of the easier changes I had in mind for moving towards the design linked above.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@aljoscha aljoscha requested review from a team as code owners January 13, 2025 10:53
@aljoscha aljoscha requested a review from ParkMyCar January 13, 2025 10:53
@aljoscha aljoscha changed the title storage: move methods from Stora storage: move methods from StorageController to StorageCollections Jan 13, 2025
@aljoscha aljoscha requested review from petrosagg and teskje January 13, 2025 10:55
Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nightly triggered: https://buildkite.com/materialize/nightly/builds/10836

I assume this should have no behavioral differences and is well exercised by existing tests, so no new tests required.

@aljoscha
Copy link
Contributor Author

I assume this should have no behavioral differences and is well exercised by existing tests, so no new tests required.

yep!

@aljoscha aljoscha force-pushed the storage-remove-collection-methods-from-controller branch from b5de2fd to b04f2fe Compare January 13, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants