adapter: Always set primary export of sources #30966
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when `force_source_table_syntax` was enabled, the primary export of sources was disabled. This feature was never tested and did not work. This commit reverts this feature so that the primary export is always created.
jkosh44
commented
Jan 7, 2025
Comment on lines
1040
to
1041
| // We only define primary-export details for this source if we are still supporting | ||
| // the legacy source syntax. Otherwise, we will not output to the primary collection. |
There was a problem hiding this comment.
Suggested change
| // We only define primary-export details for this source if we are still supporting | |
| // the legacy source syntax. Otherwise, we will not output to the primary collection. |
petrosagg
reviewed
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when
force_source_table_syntaxwas enabled, the primary export of sources was disabled. This feature was never tested and did not work. This commit reverts this feature so that the primary export is always created.Motivation
This PR fixes a previously unreported bug.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.