[dnr][copy_from]: Complete implementation of CSV format #30956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add OneshotSource and OneshotFormat traits * add HttpSource and CsvFormat * implement render(...) function to build a dataflow given a OneshotSource and OneshotFormat
* add new StorageCommand::RunOneshotIngestion * add new StorageReseponse::StagedBatches * add build_oneshot_ingestion_dataflow function which calls render(...) from the previous commit
* introduce a TableData enum that supports Rows or Batches * refactor the append codepath to use the new enum * refactor txn-wal to support appending a ProtoBatch in addition to Rows
* support specifying an Expr in COPY FROM * update plan_copy_from to handle copying from a remote source * add sequence_copy_from which calls the storage-controller to render a oneshot ingestion * add a new Coordinator message StagedBatches to handle the result of the oneshot ingestion asynchronously
* plumb the CSV params through to oneshot_source::CsvFormat to handle different delimiters and what not
* add support for compressed CSVs using async_compression
* various Bazel changes for the C dependencies from the compression algorithms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #30942
WIP
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.