Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments: Change wording on references to PR 7572 #30904

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

def-
Copy link
Contributor

@def- def- commented Dec 27, 2024

Showd up since it's closed: https://buildkite.com/materialize/nightly/builds/10732#01940587-8d35-4d45-a5a1-d8aa0c0f0554

#7572

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- requested a review from benesch December 27, 2024 15:31
@def- def- requested a review from a team as a code owner December 27, 2024 15:31
@def- def- requested a review from jkosh44 December 27, 2024 15:31
@def- def- enabled auto-merge December 27, 2024 15:35
@def- def- merged commit a5d7831 into MaterializeInc:main Dec 27, 2024
79 checks passed
@def- def- deleted the pr-closed-7572 branch December 27, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants