Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqllogictest: switch verbosity argument from usize to u8 #30848

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

ParkMyCar
Copy link
Member

Right now on main sqllogictest is broken with an error like:

assertion `left == right` failed: Argument `verbosity`'s selected action Count contradicts `value_parser` (ValueParser::other(usize))
  left: u8
 right: usize

Motivation

Fix issue with sqllogictest

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ParkMyCar ParkMyCar marked this pull request as ready for review December 17, 2024 14:16
@ParkMyCar ParkMyCar requested a review from a team as a code owner December 17, 2024 14:16
@ParkMyCar ParkMyCar requested a review from jkosh44 December 17, 2024 14:16
@ParkMyCar ParkMyCar merged commit c4a2c9c into MaterializeInc:main Dec 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants