Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce orchestratord deps #30842

Conversation

alex-hunt-materialize
Copy link
Contributor

Reduces orchestratord dependencies.

  • Makes workspace-hack optional in many crates.
  • Disables unused optional features of many orchestratord deps.
  • Moves the DeploymentStatus enum from environmentd to orchestratord (inverts this dependency).
  • Moves the CloudProvider enum to its own crate, so we don't need mz-sql any more.

Motivation

  • This PR refactors existing code.

Makes orchestratord easier to import and use from the cloud repo. We have conflicts with many dependencies in the materialize repo, so the fewer there are, the better.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@alex-hunt-materialize alex-hunt-materialize force-pushed the reduce_orchestratord_deps branch 6 times, most recently from c00abe9 to 8285783 Compare December 16, 2024 19:52
@alex-hunt-materialize alex-hunt-materialize force-pushed the reduce_orchestratord_deps branch 2 times, most recently from bf35fff to b86f212 Compare December 16, 2024 20:07
@alex-hunt-materialize alex-hunt-materialize marked this pull request as ready for review December 17, 2024 13:08
@alex-hunt-materialize alex-hunt-materialize merged commit 71f1ef3 into MaterializeInc:main Dec 17, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants