Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: skip building symlink forest for runfiles, i.e. set --nobuild_runfile_links #30074

Merged

Conversation

ParkMyCar
Copy link
Member

@ParkMyCar ParkMyCar commented Oct 17, 2024

Sets --nobuild_runfile_links for our build which skips building the symlink forest for Bazel's "runfiles", unless it's required.

This is a small change but it reduces the amount of I/O Bazel needs to do. I've been dogfooding it locally for months and haven't run into any issues so it should be good to go. The reason this isn't the default in Bazel is because some legacy rules rely on the old behavior.

Motivation

Less I/O in the Bazel build

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ParkMyCar ParkMyCar changed the title [WIP] bazel: experiment with --nobuild_runfile_links bazel: skip building symlink forest for runfiles, i.e. set --nobuild_runfile_links Jan 13, 2025
@ParkMyCar ParkMyCar requested a review from def- January 13, 2025 14:17
@ParkMyCar ParkMyCar marked this pull request as ready for review January 13, 2025 14:17
@ParkMyCar ParkMyCar merged commit 2c5c1d0 into MaterializeInc:main Jan 13, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants